Change prepack npm script to prepare #1733
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any idea why the CI build is failing? The log looks cryptic. |
|
I don't know. 😢 It might be a problem with the cache of dependencies because we changed dependencies in #1732. Let's check after that is merged. |
|
Closing as we were not able to solve the above issue... |
|
Maybe this issue is related? trufflesuite/truffle#1659 |
|
Seems to be the same thing, yeah. |
This was referenced May 11, 2019
Merged
DrGirlfriend
pushed a commit
to adobe/aio-cli-plugin-asset-compute
that referenced
this pull request
May 14, 2020
…#7) - adapt test-worker for aio projects: + run tests for all workers by default + new option "-a" to select which worker's tests to run + add missing "testcase" argument for test-worker + error test case if it specifies both a rendition and an expected error + improve test log output: timing at the end in separate color (yellow) + set request id to testcase name for easier build/test.log reading - adapt run-worker for aio projects: + new option "-a" to select which worker to run + not required if there is only one worker + exit with non-zero code if it fails - using "aio app deploy" to build action.zip from manifest instead of nui package.json solution based on serverless - removing serverless and serverless-nui dependencies and related code - refactoring from promise hell to async/await - refactoring to split up worker test & run logic in separate pieces: + WorkerTestRunner + WorkerRunner + OpenwhiskActionRunner + MockServer, one per mocked file/domain - refactored into separate functions, clearer error handling - renamed testfiles.js to cloudfiles.js describing it better - drop emoji prefixes (e.g. flower) from log messages - switch oclif manifest creation from "prepack" to "prepare" script to fix installing from git npm/npm#19564 OpenZeppelin/openzeppelin-contracts#1733 - add globby to fix issue with oclif-dev: oclif/oclif#132 - add missing semicolons - enforce 4 space indentation - finally fix old issue with repeated logs in build/test.log - handle ctrl+c and stop any running containers + cleanup directories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm allows installing a dependency directly from a git repository, but in those cases the build script needs to run locally on the computer that is installing. The
prepackscript is supposed to accomplish that but there is bug in npm and it runs without dev dependencies installed (npm/npm#19564). Switching topreparefixes that. As a side effect, now runningnpm installin the project will not only install dependencies but also run the build script, but this is not a big deal IMO.