Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow ERC20._transfer from the zero address. #1752

Merged
merged 10 commits into from
May 16, 2019
Merged

Disallow ERC20._transfer from the zero address. #1752

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
aa4cd0b
Add requirement of non-zero from to ERC20 transfer.
nventuro May 15, 2019
8a74793
Add test for transferFrom zero address to behavior.
nventuro May 15, 2019
3940149
Create ERC20.transfer behavior.
nventuro May 15, 2019
cf011e1
Add tests for _transfer.
nventuro May 15, 2019
73f7fbb
Add changelog entry.
nventuro May 15, 2019
2a90883
Fix linter error.
nventuro May 15, 2019
5fe5dd1
Delete repeated test.
nventuro May 15, 2019
e618dce
Fix hardcoded error prefix.
nventuro May 15, 2019
dd36523
Update CHANGELOG.md
nventuro May 16, 2019
8989f4c
Address review comments.
nventuro May 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@

### Bugfixes:
* `PostDeliveryCrowdsale`: some validations where skipped when paired with other crowdsale flavors, such as `AllowanceCrowdsale`, or `MintableCrowdsale` and `ERC20Capped`, which could cause buyers to not be able to claim their purchased tokens. ([#1721](https://github.com/OpenZeppelin/openzeppelin-solidity/pull/1721))
* (minor): `ERC20._transfer` allowed the `from` parameter to be the zero address, so it was possible to trigger a transfer of 0 tokens from it to any other address. The zero address is not a valid destinatary of transfers, not can it emit or receive allowance, so this behavior was inconsistent. It now reverts. ([#1752](https://github.com/OpenZeppelin/openzeppelin-solidity/pull/1752))
nventuro marked this conversation as resolved.
Show resolved Hide resolved

## 2.2.0 (2019-03-14)

Expand Down