ReentrancyGuard gas optimization #1996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The previous version of The new version instead reverts immediately as soon as a re-entrant call is made (arguably allowing for easier understanding of what happened), which is why our suite detected the revert reason is different. Given that the end result is the same (re-entrant calls are ultimately reverted), I don't think this qualifies as a breaking change. |
frangio
approved these changes
Nov 23, 2019
|
is there anywhere you documented the intended gas savings from #1996 ? |
|
As mentioned above, it should reduce the number of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the changes made in #1057 and #1155 in light of the Istanbul hardfork and EIP2200.
#1992 introduced gas savings by taking advantage of the net gas metering changes, but this can be further improved upon by removing unnecessary
SLOADoperations. Thanks @jflatow for proposing this change!