Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ERC20._burnFrom #2119

Merged
merged 3 commits into from
Mar 16, 2020
Merged

Remove ERC20._burnFrom #2119

merged 3 commits into from
Mar 16, 2020

Conversation

nventuro
Copy link
Contributor

Fixes #1766.

I reimplemented it in ERC20Burnable in terms of allowance, _burn and _approve.

@nventuro nventuro requested a review from frangio March 11, 2020 20:55
frangio
frangio previously approved these changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nventuro nventuro merged commit baaadde into OpenZeppelin:master Mar 16, 2020
@nventuro nventuro deleted the remove-burn-from branch March 16, 2020 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frangio frangio frangio left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove ERC20._burnFrom
2 participants
@nventuro @frangio