Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making IERC721Receiver an interface #2225

Merged
merged 2 commits into from
May 6, 2020
Merged

Making IERC721Receiver an interface #2225

merged 2 commits into from
May 6, 2020

Conversation

julianmrodri
Copy link
Contributor

#2217

Fixes #2217

Converting IERC721Receiver into an interface as it was missed in a previous PR and was still defined as an abstract contract.

@julianmrodri
Copy link
Contributor Author

@nventuro @frangio Ready to review when you have time. Thanks!

frangio
frangio reviewed May 6, 2020
View reviewed changes
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @julianmrodri!

contracts/token/ERC721/IERC721Receiver.sol Outdated Show resolved Hide resolved
nventuro
nventuro approved these changes May 6, 2020
View reviewed changes
Copy link
Contributor

@nventuro nventuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @julianmrodri!

@nventuro nventuro merged commit 78dc377 into OpenZeppelin:master May 6, 2020
@julianmrodri julianmrodri deleted the fix/ierc721-interfaces-#2217 branch May 6, 2020 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frangio frangio frangio left review comments

@nventuro nventuro nventuro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IERC721Receiver should be an 'interface'
3 participants
@julianmrodri @frangio @nventuro