Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SPX license identifier #2235

Merged
merged 1 commit into from
May 15, 2020
Merged

Add SPX license identifier #2235

merged 1 commit into from
May 15, 2020

Conversation

nventuro
Copy link
Contributor

Fixes #2234

Not having this identifier emits a warning on Solidity ^0.6.8.

@nventuro nventuro requested a review from frangio May 14, 2020 15:31
frangio
frangio approved these changes May 14, 2020
View reviewed changes
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Does the comment need to be the first line?

@nventuro
Copy link
Contributor Author

nventuro commented May 15, 2020 •
edited
Loading

I don't think so. I was just mimicking how license text is usually displayed in source code.

@nventuro nventuro merged commit 56de324 into OpenZeppelin:master May 15, 2020
@nventuro nventuro deleted the add-license branch May 15, 2020 00:58
@uniibu uniibu mentioned this pull request May 15, 2020
Closed
nventuro added a commit that referenced this pull request Jun 8, 2020
@nventuro
Add SPX license identifier (#2235)
fac773a 
(cherry picked from commit 56de324)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frangio frangio frangio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SPDX license identifiers missing
2 participants
@nventuro @frangio