Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize the repo structure #2503

Merged
merged 41 commits into from
Feb 22, 2021
Merged

Reorganize the repo structure #2503

merged 41 commits into from
Feb 22, 2021

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Feb 2, 2021 •
edited by frangio
Loading

Fixes #2527. See the issue for more details.

PR Checklist

  • Tests
  • Documentation
  • Changelog entry

@frangio
Copy link
Contributor

frangio commented Feb 8, 2021

Notes from offline conversation:

  • Interfaces such as a IERC777Sender should go at the top level ERC777 directory.
  • Rename proxy/upgradeable to proxy/transparent and move UpgradeableProxy to proxy.
  • Maybe TimelockController should go in its own directory of standalone contracts. Does this belong in utils? This category could also contain TokenTimelock, PaymentSplitter.
  • A new enumerable directory.
  • Try to move mocks directory somewhere less visible.

@Amxx
Copy link
Collaborator Author

Amxx commented Feb 12, 2021

What about moving the mocks/* into test/mocks/* ?

@frangio frangio changed the title Reorganize the repo's structure. Reorganize the repo structure Feb 17, 2021
@Amxx Amxx marked this pull request as ready for review February 17, 2021 17:56
frangio
frangio previously approved these changes Feb 19, 2021
View reviewed changes
@frangio frangio added the on hold Put on hold for some reason that must be specified in a comment. label Feb 19, 2021
@frangio
Copy link
Contributor

frangio commented Feb 19, 2021

Will merge on Monday!

@frangio frangio removed the on hold Put on hold for some reason that must be specified in a comment. label Feb 22, 2021
@frangio frangio enabled auto-merge (squash) February 22, 2021 16:39
@frangio frangio merged commit 24a0bc2 into OpenZeppelin:master Feb 22, 2021
@frangio frangio mentioned this pull request Feb 22, 2021
Closed
@Amxx Amxx deleted the refactor/reporeorg branch February 22, 2021 23:18
codewiz added a commit to codewiz/avalanche-docs that referenced this pull request Feb 26, 2021
@codewiz
Update the url of ERC20PresetMinterPauser.sol
d7c25d1 
It was moved in this PR: OpenZeppelin/openzeppelin-contracts#2503
@codewiz codewiz mentioned this pull request Feb 26, 2021
Merged
jpop32 pushed a commit to ava-labs/avalanche-docs that referenced this pull request Mar 4, 2021
@codewiz @jpop32
Update the url of ERC20PresetMinterPauser.sol
be01bba 
It was moved in this PR: OpenZeppelin/openzeppelin-contracts#2503
@dependabot dependabot bot mentioned this pull request Mar 15, 2021
Closed
@ghidello ghidello mentioned this pull request Mar 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frangio frangio frangio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reorganize contracts for better discoverability and clarity
2 participants
@Amxx @frangio