Refactor ERC165 to use function overriding instead of storage. #2505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amxx
force-pushed
the
refactor/virtualERC165
branch
from
cdcc30e to
0604e82
Compare
frangio
reviewed
Feb 17, 2021
test/introspection/ERC165.test.js
Outdated
| @@ -9,6 +9,12 @@ contract('ERC165', function (accounts) { | |||
| this.mock = await ERC165Mock.new(); | |||
| }); | |||
|
|
|||
| it('register interface', async function () { | |||
There was a problem hiding this comment.
I think this test should be removed since it pertains to ERC165Storage and not plain ERC165.
contracts/mocks/ERC165Mock.sol
Outdated
| @@ -2,9 +2,9 @@ | |||
|
|
|||
There was a problem hiding this comment.
I think this entire file can be deleted.
There was a problem hiding this comment.
But then ERC165Storage should not be abstract, right ?
|
I've implemented the changes I suggested above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ERC165: Uses virtual/override on the supportsInterface function instead of mapping
This reduces the storage footprint of ERC165 compliant contract, thus reducing the gas cost of deploying and configuring such contracts.
PR Checklist