-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve gas efficiency of EnumerableMap #2518
Merged
frangio
merged 23 commits into
OpenZeppelin:master
from
Amxx:refactor/new-enumerablemap
Feb 18, 2021
Merged
Improve gas efficiency of EnumerableMap #2518
frangio
merged 23 commits into
OpenZeppelin:master
from
Amxx:refactor/new-enumerablemap
Feb 18, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amxx
force-pushed
the
refactor/new-enumerablemap
branch
from
February 9, 2021 10:40
7741735
to
de4b0ae
Compare
Amxx
force-pushed
the
refactor/new-enumerablemap
branch
from
February 9, 2021 10:47
de4b0ae
to
27a0a89
Compare
frangio
reviewed
Feb 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have concerns about the use of assembly but the changes to EnumerableMap
look good.
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
frangio
changed the title
Improve gas efficiency of Enumerable structures
Improve gas efficiency of EnumerableMap
Feb 18, 2021
This is good but needs a changelog. |
frangio
approved these changes
Feb 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EnumerableSet:
add
remove
EnumerableMap:
key => value
mappingGas report
Note: gas report doesn't look to be such a good indication. tests on remix show the assembly to be more efficient, but its difficult to quantify.
EnumerableSetMock.add
EnumerableSetMock.remove
EnumerableMapMock.set
EnumerableMapMock.remove
PR Checklist