Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IERC20Metadata with name, symbol and decimals #2561

Merged
merged 11 commits into from
Mar 8, 2021
Merged

Add IERC20Metadata with name, symbol and decimals #2561

merged 11 commits into from
Mar 8, 2021

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Mar 4, 2021 •
edited
Loading

Fixes #2559

PR Checklist

  • Documentation
  • Changelog entry

frangio
frangio reviewed Mar 4, 2021
View reviewed changes
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We need to add this in tokens/ERC20/README.adoc as well.

CHANGELOG.md Outdated Show resolved Hide resolved
contracts/token/ERC20/extensions/IERC20Metadata.sol Outdated Show resolved Hide resolved
contracts/token/ERC20/extensions/IERC20Metadata.sol Outdated Show resolved Hide resolved
Amxx and others added 4 commits March 4, 2021 17:10
@Amxx @frangio
Update CHANGELOG.md
c8a7866 
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
@Amxx @frangio
Update contracts/token/ERC20/extensions/IERC20Metadata.sol
a682487 
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
@Amxx
address comments from PR
53d5d51
@Amxx
Documentation update
171c135
@Amxx
Copy link
Collaborator Author

Amxx commented Mar 4, 2021

@frangio Should this be called IERC20Extended ?

@Amxx Amxx changed the title Add IERC20Metadata with name, symbol and decimals Add IERC20Extended with name, symbol and decimals Mar 4, 2021
@frangio
Copy link
Contributor

frangio commented Mar 4, 2021

I thought IERC20Metadata was good! Alternatively I'd go with IERC20Optional.

@Amxx
Copy link
Collaborator Author

Amxx commented Mar 4, 2021

I thought IERC20Metadata was good! Alternatively I'd go with IERC20Optional.

ok, that is reverted

@frangio frangio changed the title Add IERC20Extended with name, symbol and decimals Add IERC20Metadata with name, symbol and decimals Mar 4, 2021
@frangio frangio enabled auto-merge (squash) March 4, 2021 21:35
frangio
frangio approved these changes Mar 8, 2021
View reviewed changes
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is not going into 4.0, I moved the changelog entry to a new section.

@frangio frangio merged commit b8ab763 into OpenZeppelin:master Mar 8, 2021
@Amxx Amxx deleted the feature/IERC20Metadata branch March 8, 2021 22:22
@dependabot dependabot bot mentioned this pull request Mar 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frangio frangio frangio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add getter for decimals to IERC20.sol
2 participants
@Amxx @frangio