Add values() functions to EnumerableSets #2768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nventuro
reviewed
Jul 14, 2021
Comment on lines
190
to
192
| function values(Bytes32Set storage set) internal view returns (bytes32[] memory) { | ||
| return set._inner._values; | ||
| } |
There was a problem hiding this comment.
Note that returning a memory array implies reading the entire thing from storage and copying it - not sure if that was the original intent
There was a problem hiding this comment.
Also, shouldn't this be implemented for Set as Set._values(), and call that here?
There was a problem hiding this comment.
Returning a storage pointer will potentially encourage the users to write/modify it, which would break the structure. We really want to avoid this.
frangio
reviewed
Jul 14, 2021
frangio
approved these changes
Jul 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address request from #2390
PR Checklist