Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make more functions virtual #3078

Merged
merged 6 commits into from
Jan 13, 2022
Merged

Make more functions virtual #3078

merged 6 commits into from
Jan 13, 2022

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Jan 5, 2022

PR Checklist

  • Changelog entry

@Amxx Amxx requested review from JulissaDantes and frangio January 5, 2022 20:48
@Amxx Amxx mentioned this pull request Jan 7, 2022
Closed
JulissaDantes
JulissaDantes previously approved these changes Jan 12, 2022
View reviewed changes
@frangio frangio enabled auto-merge (squash) January 13, 2022 18:48
@frangio frangio changed the title Make some function virtual Make more functions virtual Jan 13, 2022
@frangio frangio merged commit ecae978 into OpenZeppelin:master Jan 13, 2022
@Amxx Amxx deleted the refactor/virtual branch January 13, 2022 20:23
@kevupton
Copy link
Contributor

any news on when this one will be published to npm?

@frangio
Copy link
Contributor

frangio commented Jan 24, 2022 •
edited
Loading

@kevupton This is published as a release candidate on npm (@openzeppelin/contracts@4.5.0-rc.0) which you can install if you want, and will come out of release candidate in 2 weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frangio frangio frangio approved these changes

@JulissaDantes JulissaDantes JulissaDantes left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Amxx @kevupton @frangio @JulissaDantes