Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make royaltyInfo(uint256 _tokenId, uint256 _salePrice) virtual #3133

Merged
merged 2 commits into from
Jan 26, 2022

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Jan 25, 2022

Should be cherrypicked in release 4.5

Fixes #????

PR Checklist

  • Tests
  • Documentation
  • Changelog entry

@Amxx Amxx requested a review from JulissaDantes January 25, 2022 14:18
@Amxx Amxx mentioned this pull request Jan 25, 2022
JulissaDantes
JulissaDantes previously approved these changes Jan 25, 2022
Copy link
Contributor

@JulissaDantes JulissaDantes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just remember to run npm run lint:sol:fix for it to take the desired format

Copy link
Contributor

@JulissaDantes JulissaDantes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@Amxx Amxx merged commit 6fb1e84 into OpenZeppelin:master Jan 26, 2022
@Amxx Amxx deleted the fix/virtualRoyaltyInfo branch January 26, 2022 16:35
Amxx added a commit that referenced this pull request Feb 8, 2022
* Make royaltyInfo(uint256 _tokenId, uint256 _salePrice) virtual

Should be cherrypicked in release 4.5

* fix lint

(cherry picked from commit 6fb1e84)
Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants