Add address to string conversion
#3403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
pcaversaccio
changed the title
address to hex conversionaddress to string conversion
frangio
requested changes
May 11, 2022
There was a problem hiding this comment.
Thank you @pcaversaccio! I agree I can imagine this will be very handy for on-chain NFT metadata.
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Amxx
previously approved these changes
May 12, 2022
|
Maybe we say that the produced address is not checksummed. |
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
|
@Amxx good point - I added the comment! Somehow the CI actions don't work on this PR? |
|
@pcaversaccio It may have been a GitHub problem. |
frangio
reviewed
May 12, 2022
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
frangio
approved these changes
May 13, 2022
There was a problem hiding this comment.
Thanks @pcaversaccio! I made some small changes to the tests.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new function to the
Stringslibrary that converts anaddressto its ASCIIstringhexadecimal representation. The main motivation is the reason that I've encountered already multiple projects that use a sophisticatedtokenURIstrategy, that concatenates multiple attributes - one of which is anaddress- into a string. An example:PR Checklist