Optimize Address.functionCall removing redundant isContract check #3469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @ZumZoom for this interesting proposal. Do you have any metrics on the gas savings this can produce? |
|
Here are gas reports from relevant tests. TLDR: saves 108 gas when checks are not triggered (which is probably the most used case due to SafeERC20 library) and loses 26 gas when checks are triggered. Master PR |
Amxx
previously requested changes
Jun 20, 2022
There was a problem hiding this comment.
With this PR, there are two version of verifyCallResult with different arguments.
I'm worried that the two do not have the same behavior, which is not clear from naming alone:
verifyCallResult(bool,bytes,string)is not modified. It will return the data if success. Otherwise it will revert with data (if not empty) or with the fallback stringverifyCallResult(address,bool,bytes,string)is a new version. It will return the data is success and if either data is not empty or target is a contract. Otherwise it will revert with data (if not empty) or with the fallback string.
The second one forces the returns data to either be not empty, of target to be a contract, but doesn't enforce that target is actually the address that was called.
I think there is a clear possibility of user error or confusion, that we want to avoid.
|
@ZumZoom Please rename this to |
frangio
changed the title
ronhuafeng
added a commit
to ronhuafeng/openzeppelin-contracts
that referenced
this pull request
Sep 9, 2022
…enZeppelin#3469) Co-authored-by: Francisco <frangio.1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
Address.functionCall,Address.functionDelegateCallandAddress.functionStaticCallit is possible to skip target'sisContractcheck in cases where call fails or returns non-empty data. This can only happen when target has some code so there is no point in redundantisContractcheck.PR Checklist