Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make VestingWallet payable to allow funding at construction #3665

Merged
merged 2 commits into from
Aug 31, 2022
Merged

Make VestingWallet payable to allow funding at construction #3665

merged 2 commits into from
Aug 31, 2022

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Aug 31, 2022 •
edited
Loading

If PaymentSplitter's constructor is payable, then so should VestingWallet's

PR Checklist

  • Tests
  • Changelog entry

frangio
frangio approved these changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Amxx Amxx merged commit 4b8b92c into OpenZeppelin:master Aug 31, 2022
@Amxx Amxx deleted the feature/vestingWallet/payableConstructor branch August 31, 2022 18:19
ronhuafeng added a commit to ronhuafeng/openzeppelin-contracts that referenced this pull request Sep 9, 2022
@ronhuafeng
Make VestingWallet payable to allow funding at construction (OpenZepp…
d150716 
…elin#3665)
JulissaDantes pushed a commit to JulissaDantes/openzeppelin-contracts that referenced this pull request Nov 3, 2022
@Amxx @JulissaDantes
Make VestingWallet payable to allow funding at construction (OpenZepp…
7d77a0a 
…elin#3665)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frangio frangio frangio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Amxx @frangio