-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ReentrancyGuard status getter #3714
Merged
frangio
merged 15 commits into
OpenZeppelin:master
from
zhiqiangxu:add_entered_modifier
Oct 17, 2022
Merged
Changes from 7 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
3b921d3
add entered modifier
zhiqiangxu e4b9fbb
expose _status instead
zhiqiangxu 544befb
mod changelog
zhiqiangxu f5c5e67
fix naming
zhiqiangxu 77391c8
mod function name to _reentrancyGuardStatus
zhiqiangxu 9ad3c42
add test for _reentrancyGuardStatus
zhiqiangxu c841c59
mod changelog
zhiqiangxu 25461d3
add separate test for _reentrancyGuardStatus
zhiqiangxu 4c2a6d9
return boolean instead of guard value directly
frangio 2165b7f
lint
frangio 00c87df
fix compiler warnings
frangio 4cbb476
mod changelog
zhiqiangxu 2428570
Move changelog to the right section
Amxx 9d619e0
Update CHANGELOG.md
Amxx c0a712e
Merge branch 'master' into add_entered_modifier
frangio File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is getting executed, the attacker line above probably reverts.
Please add a separate test specifically for the guard status, and for the various values it can have.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for specific testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Sorry for late response, busy doing a bunch of other things lol:)