Remove the draft prefix to ERC20Permit

[Amxx]

Fixes #3790

PR Checklist

• Tests
• Documentation
• Changelog entry

[pcaversaccio]

I actually started working on a PR without realising that @Amxx has already done it :-D. In any case, I wanted to make you aware of that in docs/modules/ROOT/pages/governance.adoc & scripts/migrate-imports.js we probably also need to make the adjustments. See my commit here:

• https://github.com/pcaversaccio/openzeppelin-contracts/commit/0326538a392bd2b4cceb7416347424604f78525b#diff-fe8d0766559dcc7458e0b283082155dc4647977692e8385d1b04931fcdbbe402
• https://github.com/pcaversaccio/openzeppelin-contracts/commit/0326538a392bd2b4cceb7416347424604f78525b#diff-be3eea41b81c2bebec062279c3b97653515ff424d4595df2f8a3598192423877

I'm not yet sure about the usage of scripts/migrate-imports.js but we probably would need as well need the following lines:

'cryptography/EIP712.sol': 'utils/cryptography/EIP712.sol', // You forgot to update this in the EIP-712 update PR
'token/ERC20/ERC20Permit.sol': 'token/ERC20/extensions/ERC20Permit.sol',
'token/ERC20/IERC20Permit.sol': 'token/ERC20/extensions/IERC20Permit.sol',

[Amxx]

We are keeping the old files (as redirect to the new) for backward compatibility ... so forgetting that would not have been a major issue ... but you are right, fixing that is better !

[cpecorari]

Hi, just seen that 4.8.0 version does not include final ERC20Permit, is that a mistake because draft-ERC20Permit.sol file states :

// SPDX-License-Identifier: MIT
// OpenZeppelin Contracts (last updated v4.8.0) (token/ERC20/extensions/draft-ERC20Permit.sol)

pragma solidity ^0.8.0;

// EIP-2612 is Final as of 2022-11-01. This file is deprecated.

import "./ERC20Permit.sol";

Thanks !

[pcaversaccio]

@cpecorari no that's correct - you have to check the released version here: https://github.com/OpenZeppelin/openzeppelin-contracts/blob/v4.8.0/contracts/token/ERC20/extensions/draft-ERC20Permit.sol. I guess the release 4.9.0 will include this change - otherwise use OpenZeppelin via submodules to use the latest master version.

[frangio]

Indeed this didn't make it to 4.8. But please do not use the master branch, this is highly discouraged because the release process contributes to the security of the code.

There is nothing different in the code, so you can use the "draft" version from 4.8.