-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use default admin role in TimelockController #3799
Conversation
Socket Security Pull Request Report👍 No dependency changes detected in pull request Pull request report summary
Powered by socket.dev |
That PR looks way bigger than it needs to be. |
Seems like the PR includes everything from |
a107938
to
95a548f
Compare
Now it's ready! |
@JulissaDantes Can you rebase on |
@@ -28547,4 +28547,4 @@ | |||
"dev": true | |||
} | |||
} | |||
} | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want that ?
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
1b3e1c4
to
5da88e1
Compare
Fixes #3389
The TimelockController contract currently uses a custom non-zero TIMELOCK_ADMIN role, in order to make easier the introduction of new roles without custom migrations the DEFAULT_ADMIN_ROLE needs to be used.
PR Checklist