-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ERC1155 hooks #3876
Remove ERC1155 hooks #3876
Conversation
what about erc721? will it be different from 20 and 1155? |
Thanks for showing interest. It will be worked on after this to use the same |
@TrejGun Keep in mind that this is planned for 5.0 release which is still months away. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've merged master
into next-v5.0
which included some significant changes due to #3898. Please merge next-v5.0
into this PR as there may be conflicts.
…com/JulissaDantes/openzeppelin-contracts into refactor/erc1155-mint-transfer-burn
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Fixes #3535
The current way to customize token transfers(mint, burn, transfer) is by overriding the hooks _beforeTokenTransfer and _afterTokenTransfer. This refactor removes both hooks from the ERC1155 contract, and implements the logic inside the new
_update
internal function, so future customizations only rely on overriding a single entry point.PR Checklist