Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Strings equal tests #3902

Merged

Conversation

ernestognw
Copy link
Member

Description

Rewording tests for Strings.equal

// Already done in #3774

  • Tests
  • Documentation
  • Changelog entry

@ernestognw ernestognw requested a review from frangio December 29, 2022 16:58
@ernestognw ernestognw closed this Dec 29, 2022
@ernestognw ernestognw force-pushed the chore/improve-string-equal-tests branch from 393d0a2 to bc50d37 Compare December 29, 2022 16:59
@ernestognw ernestognw removed the request for review from frangio December 29, 2022 16:59
@ernestognw ernestognw reopened this Dec 29, 2022
@ernestognw ernestognw requested a review from frangio December 29, 2022 17:02
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slightly reworded the test titles.

@frangio frangio enabled auto-merge (squash) December 29, 2022 19:08
@frangio frangio merged commit cc27aed into OpenZeppelin:master Dec 29, 2022
@ernestognw ernestognw deleted the chore/improve-string-equal-tests branch February 15, 2023 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants