Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add keys() accessor to EnumerableMaps #3920

Merged
merged 5 commits into from
Jan 3, 2023
Merged

Add keys() accessor to EnumerableMaps #3920

merged 5 commits into from
Jan 3, 2023

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Jan 3, 2023 •
edited
Loading

Fixes #3882

PR Checklist

  • Tests
  • Changelog entry

frangio
frangio approved these changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the docs in several places including the new function said "set" instead of "map". Please review that.

@Amxx Amxx merged commit 88754d0 into OpenZeppelin:master Jan 3, 2023
@Amxx Amxx deleted the feature/EnumerableMap/keys branch January 3, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frangio frangio frangio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add method keys for EnumerableMap
2 participants
@Amxx @frangio