-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use oz-upgrades-unsafe-allow-reachable in ERC1967Upgrade #3971
Conversation
A correction, this isn't needed, but it's an improvement to this library because the unsafe-allow is used more granularly. I think this PR is doing the opposite of what we want. These functions by themselves are not safe. I was thinking it should be |
Looks good! I would actually update the changelog, it's important to mention that this requires a recent version of Upgrades Plugins ( |
🦋 Changeset detectedLatest commit: 654ef38 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This is needed to work with the latest version of the upgrade plugin.
PR Checklist