Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comment on ERC777._beforeTokenTransfer #3982

Merged
merged 2 commits into from
Feb 24, 2023
Merged

Fix comment on ERC777._beforeTokenTransfer #3982

merged 2 commits into from
Feb 24, 2023

Conversation

clayrab
Copy link
Contributor

@clayrab clayrab commented Jan 20, 2023

Simple comment cleanup

@changeset-bot
Copy link

changeset-bot bot commented Jan 20, 2023

⚠️ No Changeset found

Latest commit: ac9e176

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

wkoff25

This comment was marked as abuse.

wkoff25

This comment was marked as spam.

@clayrab
Copy link
Contributor Author

clayrab commented Jan 25, 2023

I was writing tests and wanted to make sure I had full coverage over all public functions which would call _beforeTokenTransfer(). Noticed this was missing and thought I might as well push the change up...

@frangio frangio changed the title Fixed comment on _beforeTokenTransfer() Fix comment on ERC777._beforeTokenTransfer Feb 24, 2023
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @clayrab. Note that our ERC777 implementation has now been deprecated (#4066), but for posterity I think it's good to fix this in the documentation.

@frangio frangio merged commit 2c69f9f into OpenZeppelin:master Feb 24, 2023
@gitpoap-bot
Copy link

gitpoap-bot bot commented Feb 24, 2023

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2023 OpenZeppelin Contracts Contributor:

GitPOAP: 2023 OpenZeppelin Contracts Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants