Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace revert strings with custom errors #4261

Merged
merged 122 commits into from
Jun 12, 2023

Commits on May 19, 2023

  1. Configuration menu
    Copy the full SHA
    4307e5b View commit details
    Browse the repository at this point in the history
  2. Lint

    ernestognw committed May 19, 2023
    Configuration menu
    Copy the full SHA
    ddf387c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0800e32 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    199093b View commit details
    Browse the repository at this point in the history
  5. Self review

    ernestognw committed May 19, 2023
    Configuration menu
    Copy the full SHA
    d3703bd View commit details
    Browse the repository at this point in the history
  6. Finish revert statements

    ernestognw committed May 19, 2023
    Configuration menu
    Copy the full SHA
    11931ca View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    bb3a12f View commit details
    Browse the repository at this point in the history
  8. Refactor Address.sol

    ernestognw committed May 19, 2023
    Configuration menu
    Copy the full SHA
    9f58996 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    a76e4b6 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2023

  1. Fix SignatureChecker

    ernestognw committed May 20, 2023
    Configuration menu
    Copy the full SHA
    c65b76b View commit details
    Browse the repository at this point in the history

Commits on May 21, 2023

  1. Configuration menu
    Copy the full SHA
    f58c06b View commit details
    Browse the repository at this point in the history

Commits on May 22, 2023

  1. Configuration menu
    Copy the full SHA
    810468d View commit details
    Browse the repository at this point in the history
  2. Fix proxy tests

    ernestognw committed May 22, 2023
    Configuration menu
    Copy the full SHA
    adbe841 View commit details
    Browse the repository at this point in the history
  3. First round of reviews

    Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
    ernestognw and Amxx committed May 22, 2023
    Configuration menu
    Copy the full SHA
    c29e041 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2023

  1. Configuration menu
    Copy the full SHA
    bc00094 View commit details
    Browse the repository at this point in the history
  2. Lint

    ernestognw committed May 23, 2023
    Configuration menu
    Copy the full SHA
    faf33a4 View commit details
    Browse the repository at this point in the history
  3. Bump Pragma to 0.8.19

    ernestognw committed May 23, 2023
    Configuration menu
    Copy the full SHA
    cdbea1e View commit details
    Browse the repository at this point in the history
  4. Finish token tests

    ernestognw committed May 23, 2023
    Configuration menu
    Copy the full SHA
    77eee99 View commit details
    Browse the repository at this point in the history
  5. Fix ERC20Capped

    ernestognw committed May 23, 2023
    Configuration menu
    Copy the full SHA
    ba42df6 View commit details
    Browse the repository at this point in the history
  6. Fix Address tests

    ernestognw committed May 23, 2023
    Configuration menu
    Copy the full SHA
    c31e10d View commit details
    Browse the repository at this point in the history

Commits on May 24, 2023

  1. Advancements on utils

    ernestognw committed May 24, 2023
    Configuration menu
    Copy the full SHA
    b3b7e08 View commit details
    Browse the repository at this point in the history
  2. Fix utils test

    ernestognw committed May 24, 2023
    Configuration menu
    Copy the full SHA
    960066b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b815a4f View commit details
    Browse the repository at this point in the history
  4. Fix conflicts with master

    ernestognw committed May 24, 2023
    Configuration menu
    Copy the full SHA
    99347e4 View commit details
    Browse the repository at this point in the history
  5. Lint

    ernestognw committed May 24, 2023
    Configuration menu
    Copy the full SHA
    d7d3f90 View commit details
    Browse the repository at this point in the history
  6. Add changeset

    ernestognw committed May 24, 2023
    Configuration menu
    Copy the full SHA
    5bc0812 View commit details
    Browse the repository at this point in the history
  7. Fix generation script

    ernestognw committed May 24, 2023
    Configuration menu
    Copy the full SHA
    3276d35 View commit details
    Browse the repository at this point in the history
  8. Fix flaky Create2 test

    ernestognw committed May 24, 2023
    Configuration menu
    Copy the full SHA
    23a7be2 View commit details
    Browse the repository at this point in the history
  9. Update comment in Ownable

    ernestognw committed May 24, 2023
    Configuration menu
    Copy the full SHA
    3f4f84a View commit details
    Browse the repository at this point in the history
  10. Add Unset state to TimelockController

    Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
    ernestognw and Amxx committed May 24, 2023
    Configuration menu
    Copy the full SHA
    3dc21e2 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    1c119f7 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    6541481 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    9c71d9c View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    5f8417b View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    55f0eef View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    5fe9511 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2023

  1. Replace SafeERC20's domain

    ernestognw committed May 25, 2023
    Configuration menu
    Copy the full SHA
    c927bc3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0a5bb3f View commit details
    Browse the repository at this point in the history
  3. Lint fix

    ernestognw committed May 25, 2023
    Configuration menu
    Copy the full SHA
    eac424e View commit details
    Browse the repository at this point in the history

Commits on May 29, 2023

  1. Configuration menu
    Copy the full SHA
    e11f4fa View commit details
    Browse the repository at this point in the history
  2. Fix checkpoint tests

    ernestognw committed May 29, 2023
    Configuration menu
    Copy the full SHA
    5dc5ada View commit details
    Browse the repository at this point in the history
  3. Enabled all tests

    ernestognw committed May 29, 2023
    Configuration menu
    Copy the full SHA
    44535a2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0d1d6c0 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    07d4fc9 View commit details
    Browse the repository at this point in the history
  6. Lint

    ernestognw committed May 29, 2023
    Configuration menu
    Copy the full SHA
    058b672 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2023

  1. Update contracts/governance/IGovernor.sol

    Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
    ernestognw and Amxx authored May 30, 2023
    Configuration menu
    Copy the full SHA
    1d63212 View commit details
    Browse the repository at this point in the history
  2. Update contracts/utils/Address.sol

    Co-authored-by: Francisco <fg@frang.io>
    ernestognw and frangio authored May 30, 2023
    Configuration menu
    Copy the full SHA
    276331c View commit details
    Browse the repository at this point in the history
  3. Round of review

    ernestognw committed May 30, 2023
    Configuration menu
    Copy the full SHA
    28e2e16 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2b0ce34 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2023

  1. Configuration menu
    Copy the full SHA
    4946dd9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3173d53 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6c8d0e1 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    cb79ab3 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2023

  1. Round of review

    Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.c
    om>
    ernestognw committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    be68001 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f02af6e View commit details
    Browse the repository at this point in the history
  3. Fix tests

    ernestognw committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    2d735e6 View commit details
    Browse the repository at this point in the history
  4. Round of review

    Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
    ernestognw and Amxx committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    2ecfd14 View commit details
    Browse the repository at this point in the history
  5. Round of review

    Co-authored-by: Francisco Giordano <fg@frang.io>
    ernestognw and frangio committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    b3af988 View commit details
    Browse the repository at this point in the history
  6. More review

    Co-authored-by: Francisco Giordano <fg@frang.io>
    ernestognw and frangio committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    c862ca5 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    5069bdf View commit details
    Browse the repository at this point in the history
  8. Changed Checkpoint error

    ernestognw committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    48fe940 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    c15fbf8 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    a10ee8b View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    8d62e91 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    861d341 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2023

  1. Configuration menu
    Copy the full SHA
    61a6026 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c796d15 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6a9c40f View commit details
    Browse the repository at this point in the history
  4. Review

    Co-authored-by: Francisco <fg@frang.io>
    ernestognw and frangio committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    a4063c9 View commit details
    Browse the repository at this point in the history
  5. Remove mutable variables in ERC1155 tests

    Co-authored-by: Francisco <fg@frang.io>
    ernestognw and frangio committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    5876d1c View commit details
    Browse the repository at this point in the history
  6. Remove unnecessary error

    ernestognw committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    6d8c498 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    219923b View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    1fa5acc View commit details
    Browse the repository at this point in the history
  9. Overflown -> Overflowed

    ernestognw committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    602df5a View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    4a14bec View commit details
    Browse the repository at this point in the history
  11. Review round

    ernestognw committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    ff12505 View commit details
    Browse the repository at this point in the history
  12. Lint

    ernestognw committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    65ad2e5 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2023

  1. Mooar review

    ernestognw committed Jun 3, 2023
    Configuration menu
    Copy the full SHA
    91bdb7c View commit details
    Browse the repository at this point in the history
  2. Revert ERC721 changes

    ernestognw committed Jun 3, 2023
    Configuration menu
    Copy the full SHA
    a33a4c8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2253c40 View commit details
    Browse the repository at this point in the history
  4. Lint

    ernestognw committed Jun 3, 2023
    Configuration menu
    Copy the full SHA
    892dbcc View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2023

  1. Fix tests

    ernestognw committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    028f383 View commit details
    Browse the repository at this point in the history
  2. Review suggestions

    Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
    ernestognw and Amxx committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    9c70af8 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2023

  1. Configuration menu
    Copy the full SHA
    7647774 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    45ce67f View commit details
    Browse the repository at this point in the history
  3. Moar suggestions

    Co-authored-by: Francisco <fg@frang.io>
    ernestognw and frangio committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    11092da View commit details
    Browse the repository at this point in the history
  4. Moar suggestions

    Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
    Co-authored-by: Francisco <fg@frang.io>
    ernestognw committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    6009844 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2023

  1. Configuration menu
    Copy the full SHA
    55433e7 View commit details
    Browse the repository at this point in the history
  2. Lint

    ernestognw committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    4dac3c7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    aa44323 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    cb4594f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6df52b0 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ce83461 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2023

  1. Configuration menu
    Copy the full SHA
    e5475a2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    03f1152 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7e320a7 View commit details
    Browse the repository at this point in the history
  4. Update GUIDELINES.md

    ernestognw authored Jun 8, 2023
    Configuration menu
    Copy the full SHA
    0e158b5 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2023

  1. Configuration menu
    Copy the full SHA
    f1717a6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    db4bcf9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e0949a3 View commit details
    Browse the repository at this point in the history
  4. Suggestions

    ernestognw committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    46904d7 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    3a74c47 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7bf1afc View commit details
    Browse the repository at this point in the history
  7. More suggestions

    ernestognw committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    13dd54a View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    c97d95c View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    fc1e4b0 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    27b15e3 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    2ad6e65 View commit details
    Browse the repository at this point in the history
  12. Fix test

    ernestognw committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    9304b9b View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    d4f7071 View commit details
    Browse the repository at this point in the history
  14. Applied suggestions

    ernestognw committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    88cf256 View commit details
    Browse the repository at this point in the history
  15. More suggestions

    ernestognw committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    4432ee6 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    b2aaf9e View commit details
    Browse the repository at this point in the history
  17. Fix tests

    ernestognw committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    d5815a8 View commit details
    Browse the repository at this point in the history
  18. increase gas for test

    frangio committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    d4e27a0 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2023

  1. Configuration menu
    Copy the full SHA
    73ac6dd View commit details
    Browse the repository at this point in the history
  2. document bubbling of panic code

    Amxx committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    8994817 View commit details
    Browse the repository at this point in the history
  3. Update contracts/utils/Address.sol

    Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
    ernestognw and Amxx authored Jun 12, 2023
    Configuration menu
    Copy the full SHA
    c1c6a75 View commit details
    Browse the repository at this point in the history
  4. Update test/helpers/customError.js

    Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
    ernestognw and Amxx authored Jun 12, 2023
    Configuration menu
    Copy the full SHA
    3da76b0 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4aa35c8 View commit details
    Browse the repository at this point in the history
  6. Lint

    ernestognw committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    007d6b0 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    1cd28fe View commit details
    Browse the repository at this point in the history