Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TokenTimelock, PaymentSplitter, ERC20Snapshot, ERC20VotesComp, GovernorVotesComp #4276

Merged
merged 14 commits into from
May 26, 2023

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented May 24, 2023

Fixes LIB-874

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

@changeset-bot
Copy link

changeset-bot bot commented May 24, 2023

⚠️ No Changeset found

Latest commit: e51e218

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@socket-security
Copy link

socket-security bot commented May 24, 2023

No dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No dependency changes detected in pull request

Pull request alert summary
Issue Status
Critical CVE ✅ 0 issues
CVE ✅ 0 issues
Mild CVE ✅ 0 issues
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
GitHub dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues
AI detected security risk ✅ 0 issues
AI warning ✅ 0 issues

@Amxx Amxx changed the base branch from master to next-v5.0 May 24, 2023 09:23
@Amxx Amxx changed the title Remove TokenTimelock in favor of VestingWallet Remove TokenTimelock (in favor of VestingWallet), PaymentSplitter and ERC20Snapshot. May 24, 2023
@Amxx Amxx requested review from frangio and ernestognw and removed request for frangio May 24, 2023 16:24
@frangio
Copy link
Contributor

frangio commented May 24, 2023

Upgradeable patch needs to be updated.

contracts/finance/VestingWallet.sol Show resolved Hide resolved
.changeset/clever-eagles-unite.md Outdated Show resolved Hide resolved
@Amxx Amxx force-pushed the refator/remove/TokenTimelock branch from 5a7efab to baaf484 Compare May 25, 2023 08:52
@frangio frangio changed the title Remove TokenTimelock (in favor of VestingWallet), PaymentSplitter and ERC20Snapshot. Remove TokenTimelock, PaymentSplitter, ERC20Snapshot, ERC20VotesComp, GovernorVotesComp May 26, 2023
@frangio frangio merged commit 15c5c71 into OpenZeppelin:next-v5.0 May 26, 2023
@Amxx Amxx deleted the refator/remove/TokenTimelock branch May 29, 2023 19:12
This was referenced Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants