Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace abi.encodeWithSelector & abi.encodeWithSignature with abi.encodeCall #4293

Merged
merged 5 commits into from
Jun 6, 2023
Merged

Replace abi.encodeWithSelector & abi.encodeWithSignature with abi.encodeCall #4293

merged 5 commits into from
Jun 6, 2023

Conversation

balajipachai
Copy link
Contributor

  • adds changeset
  • updates contracts: MultiCallTest, ReentrancyMock, UUPSLegacy, ERC4626, SafeERC20, SignatureChecker, ERC165Checker
  • updates utils ShortStrings.t.sol

Fixes #3693

  • All occurrences of abi.encodeWithSelector & abi.encodeWithSignature are replaced by abi.encodeCall

PR Checklist

  1. All tests are passing
  2. npm run slither returned INFO:Slither:. analyzed (429 contracts with 46 detectors), 0 result(s) found
  3. No linting issues
  4. All contracts are compiling
  • [All Passing] Tests
  • [No Changes] Documentation
  • [Added] Changeset entry (run npx changeset add)

@balajipachai
feat: replaces abi.encodeWithSelector & abi.encodeWithSignature with …
ef91e28 
…abi.encodeCall

* adds changeset
* updates contracts: MultiCallTest, ReentrancyMock, UUPSLegacy, ERC4626, SafeERC20, SignatureChecker, ERC165Checker
* updates utils ShortStrings.t.sol
@changeset-bot
Copy link

changeset-bot bot commented May 31, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: c2fbbde

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openzeppelin-solidity Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@balajipachai balajipachai mentioned this pull request May 31, 2023
Closed
Amxx
Amxx reviewed May 31, 2023
View reviewed changes
.changeset/big-plums-cover.md Outdated Show resolved Hide resolved
Amxx
Amxx reviewed May 31, 2023
View reviewed changes
Copy link
Collaborator

@Amxx Amxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment about the changeset, otherwize looks good.

Amxx
Amxx previously approved these changes Jun 1, 2023
View reviewed changes
Copy link
Collaborator

@Amxx Amxx left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Amxx Amxx requested a review from frangio June 1, 2023 07:54
@balajipachai
Copy link
Contributor Author

@Amxx @frangio Could you guys guide me to some another issue?, please, I would be more than happy to help

Amxx
Amxx reviewed Jun 1, 2023
View reviewed changes
test/utils/ShortStrings.t.sol Outdated Show resolved Hide resolved
Amxx
Amxx reviewed Jun 1, 2023
View reviewed changes
test/utils/ShortStrings.t.sol Outdated Show resolved Hide resolved
@balajipachai @Amxx
Update test/utils/ShortStrings.t.sol
c2fbbde 
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Amxx
Amxx approved these changes Jun 1, 2023
View reviewed changes
Copy link
Collaborator

@Amxx Amxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

frangio
frangio approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@frangio frangio merged commit 4fd2f8b into OpenZeppelin:master Jun 6, 2023
@guidanoli guidanoli mentioned this pull request Nov 30, 2023
Closed
This was referenced Jun 15, 2024
Open
Open
@YoutacRandS-VA YoutacRandS-VA mentioned this pull request Jun 20, 2024
Open
This was referenced Jul 9, 2024
Open
Open
This was referenced Sep 10, 2024
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Sep 10, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@RomulousApollo RomulousApollo mentioned this pull request Sep 12, 2024
Open
This was referenced Sep 12, 2024
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amxx Amxx Amxx approved these changes

@frangio frangio frangio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace abi.encodeWithSelector by abi.encodeCall
3 participants
@balajipachai @frangio @Amxx