Move upgradeToAndCallUUPS to UUPSUpgradeable #4356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a54b74f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Amxx
force-pushed
the
refactor/upgradeToAndCallUUPS
branch
from
3b20f54
to
c3aec1c
Compare
frangio
reviewed
Jun 15, 2023
ernestognw
previously approved these changes
Jun 16, 2023
ernestognw
previously approved these changes
Jun 16, 2023
ernestognw
previously approved these changes
Jun 16, 2023
Amxx
commented
Jun 16, 2023
Amxx
commented
Jun 16, 2023
Amxx
commented
Jun 16, 2023
|
We really need to agree on the guidelines for test descriptions. @Amxx and @ernestognw seem to disagree on how they should be written, based on the commit history here, and past conversations. |
frangio
approved these changes
Jun 17, 2023
This was referenced Sep 10, 2024
This was referenced Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4325 (comment)
PR Checklist
npx changeset add)