-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use explicit imports #4399
Use explicit imports #4399
Conversation
🦋 Changeset detectedLatest commit: eeecdd1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Do we want a changeset for this? |
I think it may unexpectedly remove imported values that users might rely on. I'd say yes just for making sure it's mentioned somewhere. |
undefined. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: hardhat-exposed@0.3.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for tackling this @frangio!
I just updated the docs references to also use explicit imports and added a linter rule to avoid global imports
@@ -200,11 +200,12 @@ The Governor will automatically detect the clock mode used by the token and adap | |||
// SPDX-License-Identifier: MIT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: We have to move this example code to a separate file like the others in this article.
Note that because of Solidity override resolution (
override(A, B)
) sometimes it's necessary to import an identifier even if it's only used for that.When both an interface and implementation are required, I've reused the same file for the import statement, as in: