Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement recommendations from 5.0 audit Phase 1B #4502

Merged
merged 26 commits into from
Aug 4, 2023
Merged

Implement recommendations from 5.0 audit Phase 1B #4502

merged 26 commits into from
Aug 4, 2023

Commits on Aug 2, 2023

  1. Fix M-05

    @ernestognw
    ernestognw committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    a06b352 View commit details
    Browse the repository at this point in the history

  2. Fix M-07

    @ernestognw
    ernestognw committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    316c30c View commit details
    Browse the repository at this point in the history

  3. Fix L-02

    @ernestognw
    ernestognw committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    351565f View commit details
    Browse the repository at this point in the history

  4. Fix L-03

    @ernestognw
    ernestognw committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    1bd3544 View commit details
    Browse the repository at this point in the history

  5. Fix L-04

    @ernestognw
    ernestognw committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    53b4feb View commit details
    Browse the repository at this point in the history

  6. Fix L-08

    @ernestognw
    ernestognw committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    a94adcd View commit details
    Browse the repository at this point in the history

  7. Fix L-09

    @ernestognw
    ernestognw committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    9afa6c9 View commit details
    Browse the repository at this point in the history

  8. Fix CR-01

    @ernestognw
    ernestognw committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    5a0e133 View commit details
    Browse the repository at this point in the history

  9. Fix N-22

    @ernestognw
    ernestognw committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    58546a1 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2023

  1. Fix N-21

    @ernestognw
    ernestognw committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    1164c51 View commit details
    Browse the repository at this point in the history

  2. Fix N-20

    @ernestognw
    ernestognw committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    dee9963 View commit details
    Browse the repository at this point in the history

  3. Fix N-17

    @ernestognw
    ernestognw committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    687b805 View commit details
    Browse the repository at this point in the history

  4. Fix N-19

    @ernestognw
    ernestognw committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    60329ea View commit details
    Browse the repository at this point in the history

  5. Update contracts/proxy/utils/UUPSUpgradeable.sol

    @Amxx @ernestognw
    Amxx authored and ernestognw committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    ffd9520 View commit details
    Browse the repository at this point in the history

  6. Fix R-04

    @ernestognw
    ernestognw committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    c2e835e View commit details
    Browse the repository at this point in the history

  7. Fix N-14

    @ernestognw
    ernestognw committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    7263524 View commit details
    Browse the repository at this point in the history

  8. Fix N-16

    @ernestognw
    ernestognw committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    6689060 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2023

  1. Fix L-03-2

    @ernestognw
    ernestognw committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    11213f5 View commit details
    Browse the repository at this point in the history

  2. Fix L-10

    @ernestognw
    ernestognw committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    29fd3ea View commit details
    Browse the repository at this point in the history

  3. minimize assembly in _isTrustedByTraget

    @frangio
    frangio committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    889c112 View commit details
    Browse the repository at this point in the history

  4. add changeset for VestingWallet

    @frangio
    frangio committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    13cdb42 View commit details
    Browse the repository at this point in the history

  5. merge if statements

    @frangio
    frangio committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    745b14d View commit details
    Browse the repository at this point in the history

  6. swap if statements for consistency

    @frangio
    frangio committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    3d8baba View commit details
    Browse the repository at this point in the history

  7. Revert "Fix L-10" 

    This reverts commit 29fd3ea.
    @frangio
    frangio committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    ceb19fd View commit details
    Browse the repository at this point in the history

  8. Apply suggestions from code review 

    Co-authored-by: Ernesto García <ernestognw@gmail.com>
    @frangio @ernestognw
    frangio and ernestognw authored Aug 4, 2023
    Configuration menu
    Copy the full SHA
    f9904fa View commit details
    Browse the repository at this point in the history

  9. remove whitespace

    @frangio
    frangio authored Aug 4, 2023
    Configuration menu
    Copy the full SHA
    8cb5200 View commit details
    Browse the repository at this point in the history