Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Governor module connecting with AccessManager #4523

Merged
merged 36 commits into from
Aug 16, 2023
Merged

Add Governor module connecting with AccessManager #4523

merged 36 commits into from
Aug 16, 2023

Commits on Aug 8, 2023

  1. add back GovernorTimelock

    @frangio
    frangio committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    5fd9a98 View commit details
    Browse the repository at this point in the history

  2. WIP

    @frangio
    frangio committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    1498539 View commit details
    Browse the repository at this point in the history

  3. rename GovernorTimelock -> GovernorTimelockAccess

    @frangio
    frangio committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    36dc884 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. make base delay modifiable

    @frangio
    frangio committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    2d2b087 View commit details
    Browse the repository at this point in the history

  2. remove available since

    @frangio
    frangio committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    221261f View commit details
    Browse the repository at this point in the history

  3. use relay to call the target contract

    @frangio
    frangio committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    499a2a1 View commit details
    Browse the repository at this point in the history

  4. fix warning

    @frangio
    frangio committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    d5ca8be View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. Update contracts/governance/extensions/GovernorTimelockAccess.sol 

    Co-authored-by: Ernesto García <ernestognw@gmail.com>
    @frangio @ernestognw
    frangio and ernestognw authored Aug 11, 2023
    Configuration menu
    Copy the full SHA
    7ed7c1c View commit details
    Browse the repository at this point in the history

  2. fix initial set of base delay

    @frangio
    frangio committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    bf9fdf9 View commit details
    Browse the repository at this point in the history

  3. rename maxDelay -> neededDelay

    @frangio
    frangio committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    5ced769 View commit details
    Browse the repository at this point in the history

  4. address guardian cancellation risk

    @frangio
    frangio committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    3820637 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2023

  1. use single manager per governor

    @frangio
    frangio committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    31e20a1 View commit details
    Browse the repository at this point in the history

  2. add nonces

    @frangio
    frangio committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    56ed5a4 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2023

  1. make _hashOperation private

    @frangio
    frangio committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    6ca99ef View commit details
    Browse the repository at this point in the history

  2. add docs for nonce

    @frangio
    frangio committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    e34c093 View commit details
    Browse the repository at this point in the history

  3. typo

    @frangio
    frangio committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    40adbb7 View commit details
    Browse the repository at this point in the history

  4. Update contracts/governance/extensions/GovernorTimelockAccess.sol 

    Co-authored-by: Ernesto García <ernestognw@gmail.com>
    @frangio @ernestognw
    frangio and ernestognw authored Aug 15, 2023
    Configuration menu
    Copy the full SHA
    2c41d41 View commit details
    Browse the repository at this point in the history

  5. Update contracts/governance/extensions/GovernorTimelockAccess.sol 

    Co-authored-by: Ernesto García <ernestognw@gmail.com>
    @frangio @ernestognw
    frangio and ernestognw authored Aug 15, 2023
    Configuration menu
    Copy the full SHA
    1446af0 View commit details
    Browse the repository at this point in the history

  6. Update contracts/access/manager/AccessManager.sol

    @frangio
    frangio authored Aug 15, 2023
    Configuration menu
    Copy the full SHA
    bc2bfa5 View commit details
    Browse the repository at this point in the history

  7. add proposalNeedsQueuing

    @frangio
    frangio committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    af274b1 View commit details
    Browse the repository at this point in the history

  8. remove timepoint from executed and canceled events

    @frangio
    frangio committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    bac912e View commit details
    Browse the repository at this point in the history

  9. add tests for proposalNeedsQueuing

    @frangio
    frangio committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    a1cbc83 View commit details
    Browse the repository at this point in the history

  10. Apply suggestions from code review 

    Co-authored-by: Ernesto García <ernestognw@gmail.com>
    @frangio @ernestognw
    frangio and ernestognw authored Aug 15, 2023
    Configuration menu
    Copy the full SHA
    ebd6dcd View commit details
    Browse the repository at this point in the history

  11. fix docs

    @frangio
    frangio committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    6902ad7 View commit details
    Browse the repository at this point in the history

  12. remove unnecessary override

    @frangio
    frangio committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    e96474c View commit details
    Browse the repository at this point in the history

  13. remove _authorityOverride

    @frangio
    frangio committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    452c65e View commit details
    Browse the repository at this point in the history

  14. add missing docs

    @frangio
    frangio committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    f7b3b93 View commit details
    Browse the repository at this point in the history

  15. remove unused imports

    @frangio
    frangio committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    3b47038 View commit details
    Browse the repository at this point in the history

  16. typo

    @frangio
    frangio committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    8d5e734 View commit details
    Browse the repository at this point in the history

  17. lint

    @frangio
    frangio committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    4f89411 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. add basic tests

    @frangio
    frangio committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    40eea48 View commit details
    Browse the repository at this point in the history

  2. add custom error

    @frangio
    frangio committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    0604f4d View commit details
    Browse the repository at this point in the history

  3. lint

    @frangio
    frangio committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    16519fe View commit details
    Browse the repository at this point in the history

  4. make variable private

    @frangio
    frangio committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    85148a9 View commit details
    Browse the repository at this point in the history

  5. add changeset

    @frangio
    frangio committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    a36618b View commit details
    Browse the repository at this point in the history

  6. do not delete executionPlan

    @frangio
    frangio committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    b37ed30 View commit details
    Browse the repository at this point in the history