-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop cleaning up token specific data on ERC-721 burn #4561
Merged
frangio
merged 3 commits into
OpenZeppelin:audit/wip/2a-2b
from
Amxx:feature/ERC721/extensions/dont-cleanup-on-burn
Sep 2, 2023
Merged
Stop cleaning up token specific data on ERC-721 burn #4561
frangio
merged 3 commits into
OpenZeppelin:audit/wip/2a-2b
from
Amxx:feature/ERC721/extensions/dont-cleanup-on-burn
Sep 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1896c9a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
frangio
changed the title
Do not cleanup token specific data on burn
Stop cleaning up token specific data on ERC-721 burn
Sep 2, 2023
frangio
approved these changes
Sep 2, 2023
This was referenced Sep 10, 2024
This was referenced Sep 11, 2024
This was referenced Sep 12, 2024
This was referenced Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no strong reason to reset token URI or token-specific royalties when a token is burned. In some contracts like ERC721Wrapper the token owner can arbitrarily burn and re-mint a token, and in these cases resetting this data may not be the desired behavior.
Fixes LIB-1039
PR Checklist
npx changeset add
)