Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document AccessManager functions and events in IAccessManager #4660

Merged
merged 10 commits into from
Oct 5, 2023
Merged

Document AccessManager functions and events in IAccessManager #4660

merged 10 commits into from
Oct 5, 2023

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Oct 5, 2023 •
edited
Loading

PR Checklist

  • Documentation

@Amxx Amxx requested review from frangio and ernestognw October 5, 2023 14:50
@changeset-bot
Copy link

changeset-bot bot commented Oct 5, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 98747cd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Amxx Amxx changed the title Move functions natspec comments from AccessManager to IAccessManager Document AccessManager functions and events in IAccessManager Oct 5, 2023
@Amxx @frangio
Update contracts/access/README.adoc
8b9222a 
Co-authored-by: Francisco <fg@frang.io>
frangio
frangio reviewed Oct 5, 2023
View reviewed changes
contracts/access/manager/IAccessManager.sol Outdated Show resolved Hide resolved
contracts/access/manager/IAccessManager.sol Outdated Show resolved Hide resolved
contracts/access/manager/IAccessManager.sol Outdated Show resolved Hide resolved
frangio and others added 3 commits October 5, 2023 12:20
ernestognw
ernestognw reviewed Oct 5, 2023
View reviewed changes
contracts/access/manager/IAccessManager.sol Outdated Show resolved Hide resolved
contracts/access/manager/IAccessManager.sol Outdated Show resolved Hide resolved
contracts/access/manager/IAccessManager.sol Outdated Show resolved Hide resolved
contracts/access/manager/IAccessManager.sol Outdated Show resolved Hide resolved
Amxx and others added 2 commits October 5, 2023 17:33
@Amxx @ernestognw
Apply suggestions from code review
c4787ad 
Co-authored-by: Ernesto García <ernestognw@gmail.com>
@frangio
lint
98747cd
@frangio frangio merged commit e78628b into OpenZeppelin:master Oct 5, 2023
11 checks passed
@Amxx Amxx deleted the feature/access-manager/natspec branch October 5, 2023 15:55
frangio pushed a commit that referenced this pull request Oct 5, 2023
@Amxx @frangio
Document AccessManager functions and events in IAccessManager (#4660)
d27635f 
Co-authored-by: Francisco <fg@frang.io>
Co-authored-by: Ernesto García <ernestognw@gmail.com>
(cherry picked from commit e78628b)
@GIgako19929
Copy link

3cfebcb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ernestognw ernestognw ernestognw left review comments

@frangio frangio frangio left review comments

Assignees
No one assigned
Labels
ignore-changeset
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Amxx @GIgako19929 @frangio @ernestognw