-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Math.inv function that inverse a number in Z/nZ #4839
Merged
Merged
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
9616bdf
add a Math.inv function that inverse a number in Z/nZ
Amxx 0408e14
add changeset
Amxx 989a3d6
codespell
Amxx ce04087
remove .only
Amxx 4de37d5
rewording
Amxx 8915daa
Update Math.sol
Amxx e82cbf4
more fuzzing
Amxx 658bc65
more fuzzing
Amxx 6ea4d45
refactor fuzzing
Amxx 89fca1b
using signed arithmetics more obviously matches Euclid's method and c…
Amxx 1f96c34
fix lint
Amxx 0ad5cd4
Merge branch 'master' into math/inverse
Amxx 32fbe53
fix edge case where t1 = type(int256).min
Amxx 5d9bcb5
Revert "fix edge case where t1 = type(int256).min"
Amxx d32f4da
rename Math.inv to Math.invMod
Amxx 857bea3
doc
Amxx a246570
remove unecessary check
Amxx 6f228f7
remove .only
Amxx a1fc06f
tests update
Amxx 1ccee5d
Lint
ernestognw 9a75472
Reword changeset
ernestognw 0dee9d1
Add missing point
ernestognw cadc8e7
Typo
ernestognw 284c2bb
Improve readability
ernestognw eb6b2ed
Explain overflows
ernestognw 16a10a1
Update contracts/utils/math/Math.sol
ernestognw 69000cc
@notice → @dev
Amxx f683c96
Merge branch 'math/inverse' of https://github.com/Amxx/openzeppelin-c…
Amxx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'openzeppelin-solidity': minor | ||
--- | ||
|
||
`Math`: add an `invMod` function to get the modular multiplicative inverse of a number in Z/nZ. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow now I get why the rumors of a backdoor in secp256r1, this is a weird number