Skip to content

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Feb 6, 2024

#3298 introduced a trick to expose some libraries. Without this trick, testing the upgradeable contract would fail because some vanila contract would not be exposed correctly.

hardhat-exposed@0.3.14-0 fixes that by transitivelly exposing all the imported files. In out case, that would expose Panic through the Xxx.sol → Math.sol → Panic.sol path.

I still want to note that if we ever include a library that is not used by any contract (mock or otherwise) ... then we would need to reimplement the import trick.

Copy link

changeset-bot bot commented Feb 6, 2024

⚠️ No Changeset found

Latest commit: 42888cf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/hardhat-exposed@0.3.14-0 Transitive: environment, eval, filesystem, network, shell, unsafe +344 90.5 MB

🚮 Removed packages: npm/hardhat-exposed@0.3.13

View full report↗︎

@ernestognw
Copy link
Member

I still want to note that if we ever include a library that is not used by any contract (mock or otherwise) ... then we would need to reimplement the import trick.

This is fine imo.

@Amxx Amxx enabled auto-merge (squash) February 6, 2024 17:13
@Amxx Amxx merged commit e73913c into OpenZeppelin:master Feb 6, 2024
@Amxx Amxx deleted the ci/hardhat-exposed branch February 6, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants