Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Binary heap structure #5084
Add Binary heap structure #5084
Changes from 15 commits
4fec530
8fa2eeb
792fcba
0c86005
248baf6
53db2ab
945e0f4
df82b15
8b965fc
e952cf6
f5fa274
1f0fef0
d0972a3
8e3dda6
38e1813
02f224d
7e88481
a46cc63
b2fda31
516f1ca
cf1278e
5f15d1c
32e9b49
c083d79
0e6ada0
7c98102
a1767d4
1c1e84b
0e7fe7a
d495859
fe8e902
3abeb84
8801d98
f78df0c
bb37dfb
1fb4b81
d3308c4
5b07512
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not adding Comparators here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was overlooked, and since there are currently no tests for the
Comparators
library, it missing did not triger any issue.Lets start by discussing weither we want the comparator library or not ... then we can add tests and solve that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea of having comparators so that the heap is customizable. However, this library feels odd. Is this something we see value in providing on its own file? I'd rather keep it undocumented and inside Heap.sol