Create a ERC1363Utils helper similar to existing ERC721Utils and ERC1155Utils #5133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7dda4d9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ernestognw
previously approved these changes
Aug 2, 2024
ernestognw
reviewed
Aug 2, 2024
cairoeth
reviewed
Aug 2, 2024
Co-authored-by: cairo <cairoeth@protonmail.com>
ernestognw
approved these changes
Aug 2, 2024
cairoeth
approved these changes
Aug 2, 2024
Amxx
added a commit
to Amxx/openzeppelin-contracts
that referenced
this pull request
Aug 2, 2024
…155Utils (OpenZeppelin#5133) Co-authored-by: Ernesto García <ernestognw@gmail.com> Co-authored-by: cairo <cairoeth@protonmail.com> Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Amxx
added a commit
that referenced
this pull request
Oct 2, 2024
…155Utils (#5133) Co-authored-by: Ernesto García <ernestognw@gmail.com> Co-authored-by: cairo <cairoeth@protonmail.com> Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would be usefull if someone wanted to implement a
mintAndCallfunction, for example in the context of an ERC-4626 vault with ERC-1363 compliant functions.It also replicates the design that we have in ERC721 and ERC1155.
Test are unaffected.
Moving the custom error from ERC1363 to ERC1363Utils is very slightly breaking if we put that in 5.2, after 1363 is introduced. Not breaking at all if we cherrypick that on 5.1.
PR Checklist
npx changeset add)