Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in ERC4626 docs #5222

Merged
merged 3 commits into from
Sep 23, 2024
Merged

Fix typo in ERC4626 docs #5222

merged 3 commits into from
Sep 23, 2024

Conversation

Skyge
Copy link
Contributor

@Skyge Skyge commented Sep 23, 2024 •
edited by cairoeth
Loading

Fixes typo

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 23, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 907b2ff

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Amxx Amxx added ignore-changeset documentation Inline comments, guides, and examples. labels Sep 23, 2024
@cairoeth cairoeth changed the title Fix typo in erc4626 docs Fix typo in ERC4626 docs Sep 23, 2024
@Amxx Amxx requested a review from ernestognw September 23, 2024 15:15
ernestognw
ernestognw approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@ernestognw ernestognw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ernestognw ernestognw merged commit e866815 into OpenZeppelin:master Sep 23, 2024
25 of 26 checks passed
@gitpoap-bot gitpoap-bot
Copy link

gitpoap-bot bot commented Sep 23, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 OpenZeppelin Contracts Contributor:

GitPOAP: 2024 OpenZeppelin Contracts Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@Skyge Skyge deleted the fix-erc4626-docs branch September 23, 2024 23:36
Amxx added a commit that referenced this pull request Oct 2, 2024
@Skyge @Amxx
Fix typo in ERC4626 docs (#5222)
5b95207 
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cairoeth cairoeth cairoeth approved these changes

@ernestognw ernestognw ernestognw approved these changes

@Amxx Amxx Amxx approved these changes

Assignees
No one assigned
Labels
documentation Inline comments, guides, and examples. ignore-changeset
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Skyge @Amxx @ernestognw @cairoeth