Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add introduction tag for v5.1 contracts #5228

Merged
merged 4 commits into from
Sep 27, 2024
Merged

Add introduction tag for v5.1 contracts #5228

merged 4 commits into from
Sep 27, 2024

Conversation

cairoeth
Copy link
Contributor

Fixes #5210

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

@cairoeth cairoeth added this to the 5.1-after-freeze milestone Sep 25, 2024
@cairoeth cairoeth requested review from Amxx and ernestognw September 25, 2024 22:12
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 25, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: a9abe7d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cairoeth cairoeth changed the title Add introduction version for v5.1 contracts Add introduction tag for v5.1 contracts Sep 25, 2024
ernestognw
ernestognw reviewed Sep 27, 2024
View reviewed changes
Copy link
Member

@ernestognw ernestognw left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iiuc, we're missing:

  • VestingWalletCliff
  • ERC1155Utils.sol
  • ERC712Utils.sol
  • Packing.sol

@Amxx Amxx merged commit cceac54 into OpenZeppelin:master Sep 27, 2024
21 checks passed
@cairoeth cairoeth mentioned this pull request Sep 27, 2024
Closed
2 tasks
Amxx pushed a commit to Amxx/openzeppelin-contracts that referenced this pull request Oct 1, 2024
@cairoeth @ernestognw @Amxx
Add introduction tag for v5.1 contracts (OpenZeppelin#5228)
ad8e94e 
Co-authored-by: Ernesto García <ernestognw@gmail.com>
Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Amxx pushed a commit that referenced this pull request Oct 2, 2024
@cairoeth @ernestognw @Amxx
Add introduction tag for v5.1 contracts (#5228)
6ed4b9b 
Co-authored-by: Ernesto García <ernestognw@gmail.com>
Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ernestognw ernestognw ernestognw approved these changes

@Amxx Amxx Amxx approved these changes

Assignees
No one assigned
Labels
ignore-changeset
Projects
None yet
Milestone
5.1-after-freeze
Development

Successfully merging this pull request may close these issues.

Tag introduction version in contract comments
3 participants
@cairoeth @Amxx @ernestognw