Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve VestingWallet's constructor and RSA.pkcs1Sha256 documentation #5229

Merged
merged 3 commits into from
Sep 27, 2024
Merged

Improve VestingWallet's constructor and RSA.pkcs1Sha256 documentation #5229

merged 3 commits into from
Sep 27, 2024

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Sep 26, 2024 •
edited
Loading

Fixes N-06

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

@Amxx Amxx added documentation Inline comments, guides, and examples. ignore-changeset labels Sep 26, 2024
@Amxx Amxx added this to the 5.1-after-freeze milestone Sep 26, 2024
@Amxx Amxx requested review from ernestognw and cairoeth September 26, 2024 13:53
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 26, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 03abc05

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ernestognw ernestognw merged commit ae753b7 into OpenZeppelin:master Sep 27, 2024
21 checks passed
Amxx added a commit to Amxx/openzeppelin-contracts that referenced this pull request Oct 1, 2024
@Amxx
Improve VestingWallet's constructor and RSA.pkcs1Sha256 documentation (…
d681671 
…OpenZeppelin#5229)

Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>
@Amxx Amxx deleted the audit_5_1/more-documentation_fix branch October 2, 2024 10:02
Amxx added a commit that referenced this pull request Oct 2, 2024
@Amxx
Improve VestingWallet's constructor and RSA.pkcs1Sha256 documentation (…
7623e4b 
…#5229)

Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cairoeth cairoeth cairoeth approved these changes

@ernestognw ernestognw ernestognw approved these changes

Assignees
No one assigned
Labels
documentation Inline comments, guides, and examples. ignore-changeset
Projects
None yet
Milestone
5.1-after-freeze
Development

Successfully merging this pull request may close these issues.
3 participants
@Amxx @ernestognw @cairoeth