Skip to content

Remove relative path in solhint.config.js in favor of npm virtual package #5368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Dec 13, 2024

This will allow us to simlink solhint.config.js into the community repo without having to also ship/vendor/link the corresponding module. The dependency will take care of that.

Note: we also need to make it explicit that solhint-plugin-openzeppelin uses minimatch, otherwize it won't be correctly linked when installed recursivelly as a sub-dependency of @openzeppelin/contracts

Copy link

changeset-bot bot commented Dec 13, 2024

⚠️ No Changeset found

Latest commit: fc84c7a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ernestognw
Copy link
Member

I just made sure that the package-lock was correct. LGTM if it passes the CI

@Amxx Amxx enabled auto-merge (squash) December 13, 2024 16:53
@Amxx Amxx merged commit a71f79f into OpenZeppelin:master Dec 13, 2024
17 checks passed
@Amxx Amxx deleted the solhint/remove-relative-in-config branch December 13, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants