Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated ERC721._burn(address, uint256) #1550

Merged
merged 2 commits into from
Dec 11, 2018

Conversation

nventuro
Copy link
Contributor

The old interface made no sense, since the address could only be the owner of the token. This PR adds a saner alternative, keeping the underlying behavior.

@nventuro nventuro added feature New contracts, functions, or helpers. contracts Smart contract code. labels Dec 11, 2018
@nventuro nventuro added this to the v2.1 milestone Dec 11, 2018
@nventuro nventuro self-assigned this Dec 11, 2018
@nventuro nventuro requested a review from frangio December 11, 2018 19:59
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stability 🌈

contracts/token/ERC721/ERC721.sol Show resolved Hide resolved
contracts/token/ERC721/ERC721.sol Show resolved Hide resolved
@frangio frangio merged commit dd2e947 into OpenZeppelin:master Dec 11, 2018
@nventuro nventuro deleted the deprecate-721-burn branch December 11, 2018 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contracts Smart contract code. feature New contracts, functions, or helpers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants