-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ERC721 bugfix + gas optimizations #1549
Conversation
I just noted |
Coverage dropped due to a check that is now in |
Merged #1550 and restarted the build. |
Hmm, I guess we really can't get rid of that |
I know the |
Should be ready now, @frangio PTAL. The functions for adding/removing tokens from both enumerations should be replaced by a function that receives a storage mapping (they are pretty much the same), but sadly that isn't supported in 0.4.x. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. 😊
This removes the
_addTokenTo
and_removeTokenFrom
internal
functions (which had a notice indicating they were not meant to be used, and only existed due to a language limitation, and are therefore not considered part of the API). They have been inlined into_mint
and_burn
, making it easier to understand how each function is called inERC721Enumerable
.Additionally, #839 had already been accidentally fixed in #1539, but the current implementation makes it more obvious that the issues is gone.
Fixes #839
Closes #912
Closes #1541