Fix clearing of ownedTokensIndex and allTokensIndex in ERC721Token.sol #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michald
changed the title
michald
force-pushed
the
fix-clearing-of-ownedTokensIndex-and-allTokensIndex
branch
2 times, most recently
from
9eb5eba to
53426fd
Compare
michald
force-pushed
the
fix-clearing-of-ownedTokensIndex-and-allTokensIndex
branch
from
53426fd to
60de783
Compare
frangio
reviewed
Jun 11, 2018
There was a problem hiding this comment.
Thanks @michald!
I wouldn't modify the tests for this because it's testing the implementation (evidenced by having to add a getter for an internal data structure). It's true that we try to add a test for every bug we fix, but I would argue that there was no bug here to begin with, because the value left over in storage didn't have any visible effect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #839
🚀 Description
npm run lint:all:fix).