Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix solc-nightly job #1732

Merged
merged 7 commits into from
May 2, 2019
Merged

Fix solc-nightly job #1732

merged 7 commits into from
May 2, 2019

Conversation

frangio
Copy link
Contributor

@frangio frangio commented Apr 29, 2019

Fixes #1605.

Also had to update Truffle to get this to work.

@frangio frangio added the automation Tests and coverage running. Docsite publishing. label Apr 29, 2019
@frangio frangio requested a review from nventuro April 29, 2019 23:12
nventuro
nventuro reviewed Apr 30, 2019
View reviewed changes
package.json Outdated Show resolved Hide resolved
scripts/test.sh Outdated Show resolved Hide resolved
truffle-config.js Show resolved Hide resolved
@frangio frangio mentioned this pull request Apr 30, 2019
Closed
@frangio frangio requested a review from nventuro April 30, 2019 20:33
@frangio
Copy link
Contributor Author

frangio commented Apr 30, 2019 •
edited
Loading

I also removed the build script / renamed it to prepack, because the difference between build and compile was not obvious and was very confusing. The (nasty) build script was only used to prepare the package.

@nventuro
Copy link
Contributor

nventuro commented Apr 30, 2019 •
edited
Loading

Did you chmod +x the compile script? It errors out with 'permission denied'.

@frangio
Copy link
Contributor Author

frangio commented May 2, 2019

Yeah, sorry about that.

@nventuro nventuro merged commit 9646cc9 into OpenZeppelin:master May 2, 2019
@frangio frangio deleted the solc-nightly branch May 7, 2019 21:33
@cgewecke cgewecke mentioned this pull request May 10, 2019
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nventuro nventuro nventuro approved these changes

Assignees
No one assigned
Labels
automation Tests and coverage running. Docsite publishing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix solc nightly travis job
2 participants
@frangio @nventuro