-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds negative check to event emittion #104
Adds negative check to event emittion #104
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @alejoamiras!
@frangio are these tests exhaustive enough ? Or should I test all possibilities within |
@alejoamiras These are perfect IMO. Thank you so much! |
Should we go ahead and merge? |
Great work @alejoamiras, thanks! Would you mind adding an entry on the changelog and documentation for this addition? Note that you forked before we added the documentation site proper: you'll want to rebase or merge Thanks! |
I've updated docs & changelog. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I've tweaked the description for the function a little bit because I felt it wasn't clear enough.
Great work!
No description provided.