-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: event-not-emitted support #121
Conversation
@AuHau I think you unintentionally commited style changes. Can you look into that and reverse it? And for the new code please use semicolons following the style of the rest of the project. |
0c3dbf9
to
3b3aff0
Compare
Damn, you are right. Sorry about that. It is fixed. Btw. I have to used |
I am not sure why the tests fail as I did not really do anything related to reason why they fail. It seems like they are missing |
Yes, there is a bug in Truffle, see trufflesuite/truffle#3024. I changed the This is looking great! There's a few things missing:
If there's any of this that you're not sure how to handle please let me know. |
Sounds good! I will make the changes tomorrow :-) |
Ok, ready for review :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Just a few suggestions.
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AuHau!
Support for
expectEvent.notEmitted()
.Question: Should there be support for argument specification? If so, how should be handled empty args? Should it search for an empty args event or just generally assert if an event was not-emitted?
Closes #120
I will work on changelog/docs after finalizing API/behavior.