Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope npm package #78

Merged
merged 6 commits into from
Oct 10, 2019
Merged

Scope npm package #78

merged 6 commits into from
Oct 10, 2019

Conversation

nventuro
Copy link
Contributor

@nventuro nventuro commented Oct 7, 2019

This changes the package from openzeppelin-test-helpers to @openzeppelin/test-helpers. Once 0.5.0 is published under this new name, we should deprecate the old package. I'm not sure yet if we should also publish 0.5.0 with the old name.

@nventuro nventuro requested a review from frangio October 7, 2019 21:42
@frangio
Copy link
Contributor

frangio commented Oct 7, 2019

We shouldn't deprecate all of the existing versions of openzeppelin-test-helpers because that would be very annoying for people using 0.4 who don't want to upgrade. We should publish at least 0.5.0 and then deprecate that version, so that once people upgrade they receive the recommendation to migrate.

@nventuro
Copy link
Contributor Author

nventuro commented Oct 7, 2019

Ah, I thought deprecations were package-wide. That makes a lot of sense, thanks!

Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found some things that still need changing.

npm dist-tag rm --otp "$(prompt_otp)" openzeppelin-test-helpers next

console.log(`${colors.white.bgBlack('openzeppelin-test-helpers')} ${colors.black.bgYellow('WARN')} \

@nventuro nventuro requested a review from frangio October 8, 2019 17:46
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please add a note in the Changelog.

What do you think about holding off on merging this until we actually release 0.5.0? So that we don't have to juggle to release openzeppelin-test-helpers@0.5.0.

@nventuro nventuro merged commit ca500ba into OpenZeppelin:master Oct 10, 2019
@nventuro nventuro deleted the scoped-package branch October 10, 2019 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants