-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scope npm package #78
Conversation
We shouldn't deprecate all of the existing versions of |
Ah, I thought deprecations were package-wide. That makes a lot of sense, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found some things that still need changing.
npm dist-tag rm --otp "$(prompt_otp)" openzeppelin-test-helpers next |
console.log(`${colors.white.bgBlack('openzeppelin-test-helpers')} ${colors.black.bgYellow('WARN')} \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please add a note in the Changelog.
What do you think about holding off on merging this until we actually release 0.5.0? So that we don't have to juggle to release openzeppelin-test-helpers@0.5.0
.
This changes the package from
openzeppelin-test-helpers
to@openzeppelin/test-helpers
. Once 0.5.0 is published under this new name, we should deprecate the old package. I'm not sure yet if we should also publish 0.5.0 with the old name.