Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve node mismatch warnings #80

Merged
merged 2 commits into from
Oct 9, 2019
Merged

Improve node mismatch warnings #80

merged 2 commits into from
Oct 9, 2019

Conversation

nventuro
Copy link
Contributor

@nventuro nventuro commented Oct 9, 2019

Supercedes #73

We now:

  • emit a warning but carry on when running with unknown nodes
  • throw an error when using revert reasons on older ganache versions

@nventuro nventuro requested a review from frangio October 9, 2019 19:54
@nventuro nventuro mentioned this pull request Oct 9, 2019
Closed
frangio
frangio approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nventuro nventuro merged commit 4f0ac56 into OpenZeppelin:master Oct 9, 2019
@nventuro nventuro deleted the expect-revert-evm-check-overhaul branch October 9, 2019 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frangio frangio frangio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nventuro @frangio