Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use try catch when installing chai-bn for user #85

Merged
merged 1 commit into from
Oct 16, 2019
Merged

Use try catch when installing chai-bn for user #85

merged 1 commit into from
Oct 16, 2019

Conversation

frangio
Copy link
Contributor

@frangio frangio commented Oct 16, 2019

I didn't implement #84 correctly. require throws when a module is not present (obviously), so we have to catch that and ignore it.

@frangio frangio merged commit 135c3e8 into OpenZeppelin:master Oct 16, 2019
@frangio frangio deleted the fix-chai-dependency branch October 16, 2019 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@frangio